Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 292436

Fix Block Plugin Constructor Configuration Injection

$
0
0

This is dependent upon #1927608: Remove the tight coupling between Block Plugins and Block Entities

Having worked pretty extensively trying to solve #1927608: Remove the tight coupling between Block Plugins and Block Entities I think it's apparent that the __construct() +settings() + getConfig() approach in blocks is a.) convoluted and b.) not working as desired. Furthermore a lot of work was done in Condition plugins to put together some rational expectations for constructor vs setter injection of configuration and we should adopt that and revisit the whole settings() and getConfig() magic that blocks is doing and clean it up. This should enable the value injection from the Block Entities to be cleaned up in the Block::getPlugin() method, cause that's sort of ugly in the patch in #1927608: Remove the tight coupling between Block Plugins and Block Entities.

Eclipse


Viewing all articles
Browse latest Browse all 292436

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>