Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 300130

[DISCUSSION] How to deprecate access checks?

$
0
0

Problem/Motivation

Per #2914486-119: Add granular permissions to the Layout Builder:

  1. +++ b/core/modules/layout_builder/src/Access/LayoutSectionAccessCheck.php
    @@ -27,6 +27,7 @@ class LayoutSectionAccessCheck implements AccessInterface {
    +    @trigger_error(__NAMESPACE__ . '\LayoutSectionAccessCheck is deprecated in Drupal 8.7.x and will be removed before Drupal 9.0.0. Use \Drupal\layout_builder\Access\LayoutBuilderAccessCheck instead. See https://www.drupal.org/node/3039551.', E_USER_DEPRECATED);
    

    This should say "deprecated in 8.7.0" (not 8.7.x).

    @todo Followup issue to talk about deprecations of access checks (and as compared to tagged services generally).

All known cases in Drupal core:

  1. \Drupal\layout_builder\Access\LayoutBuilderAccessCheck#2914486: Add granular permissions to the Layout Builder
  2. \Drupal\Core\Access\CsrfRequestHeaderAccessCheck#2753681: Move CSRF header token out of REST module so that user module can use it, as well as any contrib module
  3. \Drupal\quickedit\Access\EditEntityFieldAccessCheck#2267621: Deprecate and rename EditEntityFieldAccessCheck now that the module is named Quick Edit
  4. \Drupal\workflows\WorkflowDeleteAccessCheck#2896726: Expand the entity access model for workflow states and transitions.

Proposed resolution

TBD

Remaining tasks

Discuss.

User interface changes

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 300130

Latest Images

Trending Articles



Latest Images

<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>