Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 313939

Missing "edit shortcuts" contextual link on the shortcut block

$
0
0

\Drupal\shortcut\Tests\ShortcutLinksTest::testShortcutBlockAccess()

Problem/Motivation

There is no contextual link to edit the list of shortcuts on the Shortcuts block.

The shortcuts block with contextual links

Proposed resolution

Add a shortcut.contextual.yml to add a Edit shortcuts link.

Remaining tasks

Contributor tasks needed
TaskNovice task?Contributor instructionsComplete?
Create a patchInstructions
Add automated testsInstructions
Manually test the patch NoviceInstructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standardsInstructions

User interface changes

An added contextual link in the shortcut block. No new UI elements.

API changes

None.

Data model changes

None.

Original report by David_Rothstein

The shortcuts provided by the shortcut module can be displayed in the toolbar, but the module also provides a block. As originally pointed out by @jhodgdon at #647084: Missing shortcut edit and delete operations on shortcuts admin (but moved here since that issue has evolved into other things), the block does not have an "edit shortcuts" link in it like the toolbar does. It needs to.

Should be pretty straightforward to implement - the one complication I can see is that this is crying out to be done with contextual links. However, not all users have access to see contextual links, and if you have edit rights on the shortcut set but don't see the link on it, this could be a problem (unless we make sure that all classes of users have some other path to editing their shortcut set via the UI, they really need this link available on the block). So we might have to go with a basic text link in the body of the block for now.


Viewing all articles
Browse latest Browse all 313939

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>