Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 293784

[policy, no patch] Credit reviewers in commit messages

$
0
0

Updated: Comment #0

Problem/Motivation

The current commit messages credit anyone who has uploaded a new version of a patch, even if they have just done an easy reroll. By contrast, reviewers are never credited, even if they have provided significant feedback across multiple reviews. This seems unfair. It also means reviewers don't share the responsibility for the patch when just looking at the commit log.

Proposed resolution

Adjust the commit message to credit reviewers, suggested format:

Issue #1234567 Title of issue; code by a, b, c; reviewed by d; thanks to e, f

- 'code by' is the current list of reviewers.
- 'reviewed by' is the person who marked it RTBC.
- 'thanks to' is anyone else who commented on the issue.

Remaining tasks

Discuss. Agree.

User interface changes

The issue summary will be shown when looking at recent commits, rather than some of the contributors.

API changes

dreditor and drupalcores should be updated to take account of the new format.


Viewing all articles
Browse latest Browse all 293784

Trending Articles