Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 294458

Make Block module pass Coder Review

$
0
0

Part of meta-issue #1518116: [meta] Make Core pass Coder Review

  • Block module fails on the Drupal 8 branch test code review tab. The failures are NOT itemized on that tab.
  • Drupal Code Sniffer reports one error with the latest patch here applied:

    FILE: /home/quickstart/websites/d8.dev/core/modules/block/block.api.php
    --------------------------------------------------------------------------------
    FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
    --------------------------------------------------------------------------------
    335 | ERROR | global variables should start with a single underscore followed
         |       | by the module and another underscore
    --------------------------------------------------------------------------------

    This is, of course, a false positive. See this issue for fixing it: #1535558: $language_interface missing from global variables whitelist.
  • Coder Review finds no problems at the minor (strictest) severity warning level.

Viewing all articles
Browse latest Browse all 294458

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>