Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 300130

Multiple select element is inappropriately targeted with CSS in settings tray

$
0
0

Problem/Motivation

In #2826722: Add a 'fence' around settings tray with aggressive CSS reset., insufficient testing resulted in multiple select elements being styled in an unusable manner:

Broken multiple select screenshot

Proposed resolution

Update 'core/themes/stable/css/core/dialog/off-canvas.form.css' as follows:

  #drupal-off-canvas input[type="radio"] {
    -webkit-appearance: radio;
  }
-  #drupal-off-canvas select {
+ #drupal-off-canvas select:not([multiple]) {
    -webkit-appearance: menulist;
    -moz-appearance: menulist;
  }
+ #drupal-off-canvas select[multiple] option {
+   color: initial;
+   background: initial;
+ }
  #drupal-off-canvas option {
    display: block;
    font-family: "Lucida Grande", "Lucida Sans Unicode", "liberation sans", sans-serif;

The following is the result:

Fixed multiple select screenshot

Remaining tasks

  • Submit patch
  • Community review
  • Commit

User interface changes

Multiple select elements rendered in the settings tray will be styled in a useable manner.

API changes

None.

Data model changes

None.

Release notes snippet

None.


Viewing all articles
Browse latest Browse all 300130

Latest Images

Trending Articles



Latest Images

<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>