Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 292538

Handle oEmbed resources without an explicit height

$
0
0

Problem/Motivation

The oEmbed system requires all non-link resources (i.e., photos, videos, rich text) to have an explicit, non-zero width and a height defined, and throws exceptions (in \Drupal\media\OEmbed\Resource::__construct()) if they don't. This is in keeping with the oEmbed specification. However, some oEmbed providers, like Twitter and Instagram, disobey this rule because the assets they serve contain live text, and may be responsive, and there can't really have a known, predefined height. Therefore, they will be incompatible with our oEmbed implementation.

Proposed resolution

Loosen our adherence to the oEmbed standard in order to support remote assets with dynamic heights.

Remaining tasks

Figure out the best approach, write a patch with tests, and commit it.

User interface changes

None.

API changes

TBD, but likely a couple fewer exceptions will be thrown.

Data model changes

Likely none.


Viewing all articles
Browse latest Browse all 292538

Trending Articles