Quantcast
Viewing all articles
Browse latest Browse all 295277

NodeRouteProvider should extend DefaultHtmlRouteProvider

Problem/Motivation

NodeRouteProvider does not extend DefaultHtmlRouteProvider. Thus, it contains duplicated logic.

Proposed resolution

Make NodeRouteProvider extend DefaultHtmlRouteProvider.

Remaining tasks

Review.

User interface changes

None.

API changes

If someone has a route provider that extends NodeRouteProvider and has e.g. a getCanonicalRoute() with different parameters than DefaultHtmlRouteProvider this could break. I think that is something we can get away with in a minor version but I guess we could write a change notice to be nice.

Data model changes

None.


Viewing all articles
Browse latest Browse all 295277

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>