Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 298677

Setter injection arguments are not checked for unmet dependencies

$
0
0

Problem/Motivation

This is a follow-up to #2863986: Allow updating modules with new service dependencies.

Original motivation:

When a module update introduces a dependency on a new module and adds a service with a dependency on a service of the new module. The system breaks and the update hook can not be called because the service container can not be built.

The fb_instant_articles module facilitates setter injection in its services.yml, the arguments of these calls are not checked by the fix in #286398 breaking the system.

Proposed resolution

Take setter arguments into account when checking for dependencies.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 298677


<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>