Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 301140

Inline labels in classy theme do not clear floats

$
0
0

Problem/Motivation

When choosing inline labels in "manage display," the classy theme (and template) attaches a "field--inline-label" class to the div that contains the inline field and label. Then, the inline label contains a class ".field--label-inline .field__label" that floats the label left.

However the enveloping div should include a "clearfix." Because clearfix is missing, any subsequent non-text fields will float up onto one line.

This bug can often be disguised if a field containing an inline label is a text field, since text fields automatically contain a clearfix, or when a field using an inline label is followed by a text field, since that clearfix will clear the float from the prior inline label.

NOTE: Since Bartik uses classy as a base theme, the problem occurs there as well.

Proposed resolution

Add a clearfix class to the div enclosing the field label and field contents in the template, OR

Create a ".field--label-inline" class for the div only, that will clear the label's float in "core\themes\classy\css\components\field.css"

Remaining tasks

User interface changes

API changes

Data model changes


Viewing all articles
Browse latest Browse all 301140

Trending Articles