Problem/Motivation
Discovered in #3003586-21: [PP-4] Use setStorageRequired() instead of overriding the storage schema to mark fields as NOT NULL in the database where the update test fails. The problem is that the only returned revision metadata key in
/**
* Move revision metadata fields to the revision table.
*/
function system_update_8400(&$sandbox) {
for the block content entity type is workspace when retrieving the keys with $revision_metadata_fields = $entity_type->getRevisionMetadataKeys();. The problem is that the BC layer runs only when the property is not initalized or matches the required revision metadata keys property. However a Workspaces update 8801 updates only the one property inbworkspaces_update_8801().
Potentially there might be a similar problem in workspaces_module_preinstall().
Proposed resolution
In the update modify both properties on the installed entity type similar to the system update 8501 - revision_metadata_keys and requiredRevisionMetadataKeys.
Updating both properties will allow the BC layer to run property.