Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295557

Update normalize.css to the most recent version

$
0
0

Problem/Motivation

As part of #3094468: [plan] Update core JavaScript (and CSS) dependencies prior to 9.0.0-beta1 we need to update Normalize.css to the most recent version - 8.0.1

Proposed resolution

Update it. Then, evaluate the changes (which are considerable) and determine which would cause regressions in core and provide customizations that address the regressions.

User interface changes

The goal is for there to not be any

Previous issue summary (to help make sense of the first 3 years of comments)

Problem/Motivation

Firefox 49 is out and has support for <details> which means our polyfill doesn't kick in. Normalize.css sets <details> and <summary> element as display:block which means Firefox won't display the marker, they fixed this in 5.0.0 (https://github.com/necolas/normalize.css/issues/604).

Checkout comparison aligned by @droplet: (removed comments & unchanged rules, re-reordering to match v3)
https://www.drupal.org/files/issues/diff-manual-aligned-by-%40droplet.patch

Here are the change logs for Normalize.css, starting at 4.0.0 (scroll up): https://github.com/necolas/normalize.css/blob/f06565fe8e0e1ad1b88f273271.... There are a lot of changes due to reorganization/sectioning of the code as well as comment changes.

There is one notable change that causes a regression in, at least, Seven: https://github.com/necolas/normalize.css/commit/02c5c7adbbec1707900fde86..., see the attached screenshot.

There may be regressions upgrading from 3.0.3 to the most recent normalize.css.

Proposed resolution
Upgrade core's Normalize to most recent version.
Normalize 3.0.3 should be copied to Stable. Stable needs to continue using 3.0.3 for BC.


Viewing all articles
Browse latest Browse all 295557


<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>