Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 300183

views_update_8500() inlines configuration changes instead of this being done on config save for bc

$
0
0

Problem/Motivation

#2846614: Incorrect field name is used in views integration for multi-value base fields (CR) changed the naming used for multi value base fields in views. It was noted in the CR/issue that this might be a BC break with #199.

For backwards compatibility, we should be converting configuration on config save, as has been done for other issues, however the patch that was committed makes the change inline in the update. Therefore installation of custom or contributed modules with affected configuration is broken.

Proposed resolution

Move the configuration change logic from the update handler to hook_view_presave(), a post update should be added to resave the views.

See https://api.drupal.org/api/drupal/core%21modules%21views%21views.module/... for existing examples of backwards compatibility logic for views config.

views_post_update_table_display_cache_max_age() is an example of a views post update using ConfigEntityUpdater


Viewing all articles
Browse latest Browse all 300183

Latest Images

Trending Articles



Latest Images

<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>