Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 294737

\Drupal\editor\Ajax\EditorDialogSave::__construct() should typehint as an array instead of a string

$
0
0

All the usages for new EditorDialogSave($values) is passing in $form_state->getValues(), but the phpdoc for the __construct() method and the $values property says it should be a string. That appears to be incorrect and it should typehint as an array.

  /**
   * An array of values that will be passed back to the editor by the dialog.
   *
   * @var string // But this just said above it would be an array???
   */
  protected $values;
Method
    __construct
Found usages  (2 usages found)
        web\core\modules\editor\src\Form  (2 usages found)
            EditorImageDialog.php  (1 usage found)
                EditorImageDialog  (1 usage found)
                    submitForm  (1 usage found)
                        232 $response->addCommand(new EditorDialogSave($form_state->getValues()));
            EditorLinkDialog.php  (1 usage found)
               EditorLinkDialog  (1 usage found)
                    submitForm  (1 usage found)
                        85 $response->addCommand(new EditorDialogSave($form_state->getValues()));

Viewing all articles
Browse latest Browse all 294737

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>