Properly deprecate AssertLegacyTrait::assert

Problem/Motivation

AssertLegacyTrait::assert is meant for removal in Drupal 10.

Proposed resolution

Deprecate the method and remove its usage in core.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet