| heddn | Lucas, its sunny today. I need cheering up. |
| damienmckenna | Damien's here, it has been a while. |
| mikelutz | Hello. |
| narendra.rajwar27 | Hello everyone.. |
| quietone | Vicki. This too shall pass |
| damienmckenna | @quietone: .. like a kidney stone :wink: |
| steinmb | Raise his hand |
| quietone | @damienmckenna sure, why not? |
| benjifisher | Benji Fisher. I live in Massachusetts in the US. For a while, we were near the top of the list of US states in number of COVID-19 cases, but our numbers have been going down and we are serious about contact tracing. |
| dinarcon | Hello everyone :wave: I will be updating the examples of the 31 days of migration series to Drupal 9 very soon. Almost everything can be ported with minimal effort. And in the near future I hope to release an updated version of the series covering the latest developments and new things I have learn over the last year. :slightly_smiling_face: (edited) |
| Nick Dickinson Wilde | Nick, he/him, My island - Vancouver Island BC, pop 870k, has zero active COVID cases - and no new ones for 3 weeks. |
| sharma.amitt16 | Hey everyone.. ahhh little but late |
| alison | Hi! We had an awesome socially distanced outdoor, small-group-shifts baby shower this weekend for my sister in law, it was really fun, gorgeous weather, great people. |
| heddn | @alison it might just be me, every time I see your profile photo I have to double take cause I think it looks like a moose! But its a dog. |
| benjifisher | It looks like a :cow: to me. |
| alison | hahaha that cheers me up, too :D I've heard cow before, but not moose. Love it. |
| ashishdalvi | Ashish Dalvi from India.I am here for the first time. Curious to know more about initiative and looking forward to start my contribution.Its first rain season in mumbai, India :slightly_smiling_face: |
| benjifisher | @ashishdalvi: Welcome! Have a look at 8️⃣ . That might be a good place to start. |
| ashishdalvi | Thanks @benjifisher Taking look at it. |
| benjifisher | @andypost suggested that we discuss #3039240: Create a way to declare a plugin ID defined in a yml file as deprecated |
| heddn | Its been sitting in NR for way to long. Anyone want to just mark it RTBC to get the next step started? |
| quietone | If I understood the comment correct, andypost was suggesting that we add into that patch the deprecation of the action_setting plugin as an example. |
| andypost | Hey, last time I checked it was not ready |
| andypost | It missing example and test |
| andypost | So I suggested actions |
| benjifisher | Maybe the status should be NW. |
| andypost | For me the question is chicken-egg - allow deprecation with synthetic example or use it for actions in the same issue (edited) |
| heddn | use it for action in same issue. that way it dog foods its own. |
| heddn | +1 on NW and using a real example. if there are others that need to do the same later, we can pick that up in follow-ups. $0.02 |
| damienmckenna | #3150733: Drupal 9 compatibility fixes for Commerce Migrate |
| damienmckenna | I did some of the simpler changes, I didn't have the time to get into some of the more detailed ones. I also haven't tested the changes, hopefully I didn't break anything :wink: |
| heddn | @damienmckenna would a commit of the .info.yml changes help you with any testing? |
| damienmckenna | @heddn: It might help others, and make the testbot be able to run it against D9. |
| damienmckenna | I haven't checked the dependencies yet either. |
| damienmckenna | (though Commerce is on D9 already, so that's a good step forward) |
| heddn | @damienmckenna when you feel it is ready, I can commit it so we can keep up the velocity. |
| damienmckenna | :thumbsup_all: |
| heddn | just ping me :slightly_smiling_face: |
| damienmckenna | I have two D7 projects that want to upgrade, one has Ubercart, the other has Commerce, so I'll see if I can help on this. |
| quietone | Ping me as well. |
| benjifisher | #2607524: [meta] Migrations from Drupal 8 to Drupal 8 and Drupal 8 to Drupal 9 |
| heddn | I think we should move forward with using json as the source for d8 => d9. anyone want to open up an issue to add a json source plugin to core that can handle our rest api? |
| benjifisher | FYI we have been discussing improved support for JSON:API as a migration source. If it works, then this could reduce a many-to-many problem (migrating from D8, D9, with multiple minor versions to D9, D10, multiple minors) to a many-to-one problem (already solved by the JSON:API module) and a one-to-many problem. |
| benjifisher | I think that issue already exists. Maybe on the Migrate Plus queue. |
| dinarcon | Is the goal to move Migrate Plus' url plugin and the JSON parser into core? Or will both coexist? |
| heddn | @benjifisher the json parser in migrate plus has very little tests, has lots of issues and doesn't use any more of a JSON api then json_decode. Let's build something from the ground up with test coverage |
| heddn | Burn it to the ground and start over again. |
| benjifisher | Well, the issue exists. A couple of people said they had done initial work, but IIRC they did not post much in the way of patches. |
| benjifisher | You think it would be a bad idea to develop it in contrib and plan to move it into core? |
| heddn | The fetcher / parser paradigm is another question... JSON doesn't technically need it. But we do have some precedence with the download and file_copy chained plugins in core. I'd be inclined to say we use download. then just parse it after download. is less to boil of the ocean then trying to add fetcher/parser $0.02. (edited) |
| heddn | @benjifisher yes, because BC. We already have a contrib solution. It needs to be burned to the ground. And we're talking about json parsing. Nothing super fancy. < 300 lines of code for the source plugin if I had to guess |
| heddn | BC, because adding a new one to contrib means a new name. Then moving it to core. Just a nightmare. Do it right with good test coverage and there's no need. |
| dinarcon | Ha, I just realized that file_copy automatically uses download for remote URIs. Nice. I wonder if it would pass along guzzle_options? In any case, not having to manually specify a local or remote configuration as with the data fetcher plugin is very nice. This would simplify the configuration and make it easier to grasp. (edited) |
| heddn | @dinarcon yes, it does pass those along |
| dinarcon | Sweet |
| quietone | Is there a core issue for this? |
| quietone | I want to update the issue |
| benjifisher | I do not think there is a core issue yet, and the one for Migrate Plus is no longer on d.o: https://gitlab.com/drupalspoons/migrate_plus/-/issues/224 |
| benjifisher | Should we create a new core issue for JSON:API? Regular issue or meta? Or should we change the title and scope of the existing meta? |
| quietone | A new issue please. |
| benjifisher | It is also related to #3114899: Future of migrate in core in a post Drupal 7 world |
| benjifisher | I think that @heddn also suggested that some sort of DRY solution for migrations would work well with a JSON:API source. Another issue that is no longer on d.o: https://gitlab.com/drupalspoons/migrate_plus/-/issues/133 |
| benjifisher | I added an issue: #3150949: Add a migration source plugin for JSON:API. I am not sure:task or feature request?Normal or Major? |
| benjifisher | #2993367: Add the migration from D7 Picture to Responsive Image |
| benjifisher | I have a couple of nits, like s/it's/its in a comment. But it is pretty big and complicated, and it would take me a while to do an honest review.Both @heddn and @mikelutz have reviewed this in the past. Could one of you take this on? |
| quietone | Yea, this is part of the meta for the D7 upgrade path and needs progress. |
| mikelutz | I'm fine to rtbc it, but if you want to point out nits, go for it. |
| benjifisher | OK. The good part about nits is that they are easy to fix. |
| quietone | @benjifisher if appropriate tag it as novice, and if no one does it I will do it when I wake up. |
| heddn | @quietone go to sleep already!!! |
| benjifisher | I added my nits, marked it as Novice, and set to NW. |
| benjifisher | The patch needed a reroll in addition to my nits. All done now. @mikelutz, can you take it from here? |
heddn, damienmckenna, mikelutz, narendra.rajwar27, quietone, steinmb, benjifisher, dinarcon, Nick Dickinson Wilde, sharma.amitt16, alison, ashishdalvi, andypost