Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 292853

Remove 'Add views row classes' setting from all formats as it has no effect on output

$
0
0

Problem/Motivation

The 'Add views row classes' option in views format settings does not change the output of the view, as documented in #2474491-4: Remove 'Add views row classes' setting from all formats as it has no effect on output. The markup is the same whether this is on or off.

Proposed resolution

Assuming that not adding row classes is the expected behaviour (based on #2474491-6: Remove 'Add views row classes' setting from all formats as it has no effect on output remove this option from the UI.

Remaining tasks

  1. Confirm that we don't want to add numbered row classes
  2. Confirm removal of the option will not result in any changes to output of existing views
  3. Remove the checkbox from the UI

User interface changes

Remove this checkbox from the UI.

API changes

n/a

Data model changes

n/a

Release notes snippet

Original IS:

Problem/Motivation

When using the "Table" style plugin, the default_row_class setting is not respected and the classes are not added as expected. I would expect something like views-row-n, views-row-last etc

Proposed resolution

Add back the classes that used to be there in D7.

Remaining tasks

Review the proposed approach + write tests.


Viewing all articles
Browse latest Browse all 292853

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>