Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 294215

Deprecate user_picture_enabled() reconsider user picture field

$
0
0

Problem/Motivation

Follow-up to #3072305-45: Notice: Undefined index: #item in user_user_view_alter()
It is used in system module (indirect dependency on user) via \Drupal\system\Form\ThemeSettingsForm::buildForm()
Function used only 3 times in contrib http://grep.xnddx.ru/search?text=user_picture_enabled
Current implementation does not check that user_picture field is image and added by standard profile
There's few known bugs with it

Proposed resolution

- reconsider usage of user_picture field
- deprecate user_picture_enabled() and move all related functionality to helper

Remaining tasks

- discuss, figure less buggy implementation
- patch and commit

User interface changes

tbd

API changes

tbd

Data model changes

no

Release notes snippet

tbd


Viewing all articles
Browse latest Browse all 294215

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>