Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 302836

Regression: "Translate" local task always visible, also for entities that do not have translation enabled

$
0
0

Problem/Motivation

When the content translation module is enabled, the "Translate" local task is always visible, even if content translation has not been enabled for the bundle.

Steps to replicate

  1. Install a new site with the minimal profile.
  2. Enable the Language and Content Translation modules.
  3. Verify at /admin/config/people/accounts that content translation has NOT been enabled for users.
  4. Go to /user/1

Result: the "Translate" tab is shown and displays an empty translation overview when clicked. This appears to occur for all entities (confirmed for nodes and taxonomy terms).

Screenshot of user translation not enabled:

Screenshot of user admin with the "translate" tab showing even though translation is not enabled:

Screenshot of the empty translation overview page when "translate" is clicked:

Proposed resolution

The "Translate" tab should not be visible, and the path /user/1/translations should return an appropriate error. With this patch from #28 installed a page not found error is returned if the translation modules are not enabled and an access denied error results after enabling the modules if translation is not enabled for the entity.

Remaining tasks

  • (done) Create initial patch.
  • (done/pending) Evaluate the tests before and after the patch
  • (done) Review to confirm all cases in the matrix in #31 are still satisfied.
  • address the remaining questions listed in #48.
  • (novice) Review final patch to check it fixes the issue, the change is properly documented and for coding standards. Make sure patch stays within scope of just this issue. | Contributor task documentaiton for reviewing patch

User interface changes

  • Interface link "translate" will be shown only when translation is enabled for the entity.
  • translation-overview page will be available only when translation is enabled for the entity.

API changes

None.


Viewing all articles
Browse latest Browse all 302836

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>