I assume that we are now in code cleanup phase. I use PhpStorm to find possible bugs and problems in the Drupal 8 core. Normally I will not alter code flow. If I find problems in a file, which I will not fix, but find suspicious. I'll mention it in the text here.
For changes in the PHP Documentation I use this node as guide: http://drupal.org/node/1354
Checked: tableheader.inc file.
There are a few notable things about unused variables and code in that file.
First all three use statements are used nowhere not even as Annotation.
<?php
use Drupal\Core\Database\Connection;
use Drupal\Core\Database\Query\SelectExtender;
use Drupal\Core\Database\Query\SelectInterface;
?>Secondly:
<?php
function tablesort_header($cell, array $header, array $ts) {
?>The $header is nowhere used in that function. So why keep it there? I did not touched it, but it seems ignored.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| drupal_core-doc_cleanup-tablesort.inc_.patch | 3.43 KB | Idle | FAILED: [[SimpleTest]]: [MySQL] 54,119 pass(es), 0 fail(s), and 72 exception(s). | View details | Re-test |