I assume that we are now in code cleanup phase. I use PhpStorm to find possible bugs and problems in the Drupal 8 core. Normally I will not alter code flow. If I find problems in a file, which I will not fix, but find suspicious. I'll mention it in the text here.
For changes in the PHP Documentation I use this node as guide: http://drupal.org/node/1354
Checked: session.inc file.
There is at some point the $session_id defined in a if condition and later in another if condition used regardless if the first if condition was entered, therefore I get two warnings, I did not touched.
Variable 'session_id' might have not been defined (at line 384)
Variable 'session_id' might have not been defined (at line 397)
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| drupal_core-doc_cleanup-session.inc_.patch | 3.63 KB | Idle | FAILED: [[SimpleTest]]: [MySQL] 54,188 pass(es), 1 fail(s), and 0 exception(s). | View details | Re-test |