Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 294747

[Regression] Fix inconsistent D8 ContentEntity migration source by adding include_revisions option

$
0
0

Problem/Motivation

Coming from #3184627: D8.9 breaks D8-to-foo entity migrations.

In #2746541: Migrate D6 and D7 node revision translations to D8 erroneously got inconsistent, a revision key was added toIDs of migrate\source\ContentEntity without returning all revisions.

@benjifisher resumed:

To be clear, you have now identified two problems caused by the unintended BC break:
- A recurring migration that worked on Drupal 8.8 no longer works after upgrading to 8.9 or 9.x.
- The content_entity source plugin creates a row for each revision, and there is no way to get a row for each entity.
I think we should go straight to #3184650.

Proposed resolution

Make the plugin consistent again by adding a "include_revisions" option.

Remaining tasks

- Move useful commits from #3184627: D8.9 breaks D8-to-foo entity migrations to this MR
- Decide if we want a "Updated entities trigger migration update (for include_revision=false)" test, or if we only test IDs for both code paths and rely on the migrate test for this
- That given, complete test coverage

User interface changes

None.

API changes

API addition.

Data model changes

None.

Release notes snippet

The "content_entity:*" migrate source plugin now has an option "include_revisions".


Viewing all articles
Browse latest Browse all 294747

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>