Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295840

Several IF with confusing conditions, as "a OR b AND c" without ( )

$
0
0

Confusing conditions structure:

# @file /core/modules/views/src/Plugin/views/style/Table.php, line 187
if ($field == $column || $columns[$column] == $column && !empty($sanitized[$column])) {
	  
# @file /core/modules/system/src/Controller/SystemController.php, line 249
if (!empty($theme->status) || !$theme->incompatible_core && !$theme->incompatible_php && !$theme->incompatible_base && !$theme->incompatible_engine) {

# @file /core/lib/Drupal/Core/Template/AttributeValueBase.php, line 53
if (isset($this->value) && static::RENDER_EMPTY_ATTRIBUTE || !empty($value)) {
	
# @file /core/lib/Drupal/Core/Config/Schema/SchemaCheckTrait.php, line 94
if ($element && is_scalar($value) || $value === NULL) {
	
# @file /core/lib/Drupal/Core/Database/Query/Condition.php, line 151	
if ($this->changed || isset($this->queryPlaceholderIdentifier) && ($this->queryPlaceholderIdentifier != $queryPlaceholder->uniqueIdentifier())) {
	
# @file /core/lib/Drupal/Core/Template/TwigExtension.php, line 335	
if (!isset($parameter_node) || $parameter_node instanceof \Twig_Node_Expression_Array && count($parameter_node) <= 2 &&
        (!$parameter_node->hasNode(1) || $parameter_node->getNode(1) instanceof \Twig_Node_Expression_Constant)) {
		
# @file /core/includes/file.inc, line 547	
if ($source == $destination || ($real_source !== FALSE) && ($real_source == $real_destination)) {

# @file /core/modules/views/src/Plugin/views/filter/InOperator.php, line 209
if (empty($this->options['expose']['required']) && (empty($default_value) || !empty($this->options['expose']['reduce'])) || isset($this->options['value']['all'])) {

# @file /core/lib/Drupal/Core/Entity/ContentEntityType.php, line 63
if ((isset($base_fields['revision_timestamp']) && $revision_timestamp = 'revision_timestamp') || (isset($base_fields['revision_created'])) && $revision_timestamp = 'revision_created') {

Viewing all articles
Browse latest Browse all 295840

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>