Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 292829

Deprecate masterminds/html5 as a production dependency for Drupal 10

$
0
0

Problem/Motivation

@alexpott:

We shouldn't update masterminds/html5 or jcalderonzumba/* - the PhantomJS stuff because it is very fickle with versions and basically unsupported at this point. The html5 library has proved tricky because of the amp project and it's library. See #3040037: Update masterminds/html5 to 2.6.0 for more.

@alexpott:

I’ve just realised something about masterminds/html5 and Drupal 9 - that I think we want to fix prior to RC

  1. It’s a dev only dependency but it is listed in the main deps
  2. Our d9 composer updates have updated it to a version that require a new PHP extension - ctype
  3. Funnily enough we have a polyfill for the extension so nothing is broken if you don’t have the ctype extension - there’s symfony/polyfill-ctype

Proposed resolution

@alexpott:

I think we should move it to a dev dependency and then I’d argue this does not matter

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

The masterminds/html5 is no longer a runtime dependency of Drupal and will not be included in tagged releases. Contributed or custom modules using this package need to add the dependency to their composer.json.


Viewing all articles
Browse latest Browse all 292829

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>