Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 299618

Remove 'reply' link from comment field when threading is disabled

$
0
0

Problem/Motivation

This is a followup to #81373: Allow option for comments to be completely flat (no threading in database). Copying the relevant comments here for simpliicity.

From RobLoach in #comment-21
When "Threading" is disabled, you still get the "reply" link in the Comment operations.

From andypost in #comment-22
#21 is only issue left here, also it make sense to check other code for possible optimizations when comments are not threaded
Like \Drupal\comment\CommentStorage::loadThread() does

For example:
1) no need to calculate thread and query it in \Drupal\comment\CommentStorage::getMaxThread()
2) and other places

Steps to reproduce

Standard install
Disable threading, /admin/structure/types/manage/article/fields/node.article.comment
Create an article
Add a comment
See the reply link.

Proposed resolution

Remove the reply link.

Remaining tasks

Patch
Review
Commit

Manual testing done in #17 and #22.

User interface changes

As it is:
before

As it to be:
after

API changes

No api changes


Viewing all articles
Browse latest Browse all 299618

Latest Images

Trending Articles



Latest Images

<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>