Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 291521

[META] Convert page callbacks to controllers

$
0
0

We now have a shiny new routing system that supports object-based controllers. Now we need to port core over to it!

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

If one of the issues below is open and not claimed, go ahead and claim it!

We also need to create issues for page callbacks that do not yet have them. To do so:

  1. Create a new issue, entitled "Convert name_of_page_callback() to a Controller"
  2. Include a link to the conversion guide (above) in the body of the issue.
  3. Tag the issue "WSCCI-Conversion". If it involves a form page, also tag it "FormInterface".
  4. Add the issue below to the appropriate module. Use the form [#123@], so that we can see who the issue is assigned to.
  5. Start converting!

It MAY make sense for certain page callbacks to get combined into a single Controller class. If so, just reference both from the title of the issue. (Also, make sure a page callback is not already listed below.)

What should get converted? Any entry in hook_menu() in any core module that has "page callback" in it instead of "route_name" needs to be converted. If you see one, add it here. This issue is done when there are no hook_menu implementations in core that contain "page callback".

action

aggregator

#1946324: Convert confirm_form() in aggregator.admin.inc to the new form interfaceAssigned to: rootatwc

ban

#1944910: Convert the 2 menu callbacks in ban.module to a new style controller (and form controller)Assigned to: tim.plunkett

block

book

#1938296: Convert book_admin_overview and book_render to a new-style ControllerAssigned to: disasm
#1945390: Convert book_admin_edit to a new-style FormInterface implementationAssigned to: Alan Evans

breakpoint

ckeditor

color

comment

#1946348: Convert all of confirm_form() in comment.admin.inc to the new form interfaceAssigned to: splatio

config

contact

#1938386: Convert contact_category_* pages to a new-style ControllerAssigned to: mkadin

contextual

datetime

dblog

edit

editor

email

entity

entity_reference

field

field_sql_storage

field_ui

#1946404: Convert forms in field_ui.admin.inc to the new form interfaceAssigned to: tim.plunkett

file

filter

forum

#1946414: Convert confirm_form() in forum.admin.inc to the new form interface

hal

help

history

image

#1946416: Convert all of confirm_form() in image.admin.inc to the new form interfaceAssigned to: kim.pepper

jsonld

language

layout

link

locale

menu

#1946428: Convert all of confirm_form() in menu.admin.inc to the new form interfaceAssigned to: foopang

menu_link

node

number

openid

options

overlay

path

php

picture

rdf

rest

search

serialization

shortcut

simpletest

statistics

syslog

system

#1946454: Convert all confirm_form() in system.module and system.admin.inc to the new form interface and convert route

taxonomy

telephone

text

toolbar

tour

tracker

translation

translation_entity

#1946462: Convert all confirm_form() in translation_entity.admin.inc and translation_entity.pages.inc to the new form interface

update

user

#1946466: Convert all confirm_form() in user.module and user.pages.inc to the new form interface and convert route
#1938884: Convert user_admin to a new-style ControllerAssigned to: tim.plunkett

views

xmlrpc


Viewing all articles
Browse latest Browse all 291521

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>