Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295724

Title variable isn't set by Syndicate block - so the link text is an unfinished sentence

$
0
0

Problem/Motivation

The node module provides a "syndicate" block, which contains a link to rss.xml.

The link text is an unfinished sentence: "Subscribe to".

The link is generated in SyndicateBlock.php using '#theme' => 'feed_icon'.

The corresponding feed-icon.html.twig template expects a top-level variable called title like so:

{{ 'Subscribe to @title'|t({'@title': title}) }}.

However no title variable has been passed in to the theme template by SyndicateBlock.php, so the link is an unfinished sentence. It's not clear what was originally intended for this to say. We could look back to how things worked in D7, but at this stage that might not be relevant any more.

Proposed resolution

Pass in a title in to the feed_icon template, so the link text makes sense.

I suggest we use the site name for this.

Remaining tasks

  • Update SyndicateBlock.php
  • Check tests

User interface changes

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 295724

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>