Problem/Motivation
On the image field settings form, the two field labels "Maximum image resolution" and "Minimum image resolution" should really be "Maximum image dimensions" and "Minimum image dimensions" .
Though wikipedia admits that the former is commonly used to mean 'dimensions', this tends to trip up people with print or graphic design backgrounds, who actually expect to limit an image's true resolution.
Proposed solution
In Drupal 8, We should update all the user interface text, and corresponding code to all these values dimensions instead of resolutions.
In Drupal 8 we may need to provide an update hook to move variables in the field config tables from the old D7 names to the new D8 names.
In Drupal 7, we should update only the user interface text.
Remaining tasks
- D8: Update user interface text
- D8: Update code to match UI
- D7: Update user interface text only.
User interface changes
- "Maximum image resolution" should become "Maximum image dimensions"
- "Minimum image resolution" should become "Minimum image dimensions"
API changes
- function rename (in file.module):
function file_validate_image_resolution(FileInterface $file, $maximum_dimensions = 0, $minimum_dimensions = 0) is renamed to "file_validate_image_dimensions"- method rename (in class ImageItem):
public static function validateResolution($element, &$form_state) is renamed to "validateDimensions"
Related issues
#1134022: Update "Maximum image resolution" to read "Maximum image dimensions"
#1215730: Terminology update: don't say "Resolution" when we mean "Dimensions"