- The class doxygen is useless. Is it a list of items? Can the keys be strings? What are some examples? When should I use something else for an array
getItemDefinitioncontains a fatal error. No, seriously, look at it:buildDataDefinitionis called with two arguments, it requires three. What does this say about test coverage? Do we need this method if it's not called anywhere, code or test?- All the method doxygen are the old style implements instead of inheritdoc.
onChangeis looking forparentwhich is not a defined property nor is it clear how would it be set.
↧
Move common code of Sequence/Mapping elements one level up to ArrayElement, add a specific interface
↧