Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 293204

StatementWrapperLegacyTest::testClientStatementMethod() should be less specific.

$
0
0

Problem/Motivation

The way I understand it, StatementWrapperLegacyTest::testClientStatementMethod()
is written to ensure that PDOStatement methods can run against $this->statement regardless of what the actual object is. The choice of the query that is executed, the choice of the method, and the actual result is arbitrary and not important, just that there is no exception thrown. The SQL Server driver will occasionally add extra columns to a database table, for example, if a column is labeled unique but is too many bytes in size for SQLServer to index against. Using Select * From {test} returns a different number of columns because of this, but the method does exist and does not error, which is what the test is trying to actually assert.

Steps to reproduce

Run the test using the Sqlsrv driver.

Proposed resolution

The query could be changed to anything. The choice of method could be changed as well. I propose changing the query to `SELECT id from {test}` and asserting that the column count is 1.

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None


Viewing all articles
Browse latest Browse all 293204

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>