Problem/Motivation
The way the admin toolbar renders the account link includes a flicker as the vertical position of the icon is changed (see attached screen record in the UI changes section below.).
This might have been introduced in #2899392: user_hook_toolbar() makes all pages uncacheable
Steps to reproduce
- Install core (any verison from 8.9.x to 9.3.x).
- Login as a user that can see the toolbar.
- Load a page.
- Watch the 'Account' link (head) icon closely and see it change position.
Proposed resolution
Use CSS and JS to always give toolbar icons min-height: 39px; across all core themes.
Remaining tasks
- Decide if we can change stable + stable9 like this, or if we should leave them out of this fix.
- Decide if we need a CR.
- Reviews / refinements.
- RTBC.
- Commit.
User interface changes
Removes a flicker of the 'Account' link icon in the toolbar.
Before
After
See https://www.drupal.org/files/issues/2020-08-18/desktopap.gif
API changes
None.
Data model changes
None.
Release notes snippet
TBD, probably not.