Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 298376

Include 'composer' directory in phpcs scans

$
0
0

Problem/Motivation

Recently, a new top-level directory composer was introduced. This directory holds sources for code that does not need to be packaged in the drupal/core subtree split, and therefore should not be in the core directory. However, only things in the core directory are being tested with phpcs, leading to a growing collection of coding violations in the composer location.

Proposed resolution

We should ensure that the composer directory is also sniffed for conformance with the Drupal coding standards. We could do this either by copying the phpcs configuration from the core directory, or by making a relative path from within the phpcs configuration file to the composer directory. Neither option is great, but the relative path is probably preferable to the duplicated configuration.

Remaining tasks

  • Start code-sniffing the composer directory.
  • Correct the existing coding standard violations. There are many, but phpcbf can help with most of them.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

n/a


Viewing all articles
Browse latest Browse all 298376

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>