Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 294952

Incorrect method names for dataProviders

$
0
0

Some of the code in core does not follow the phpunit standards described here
The Task is to rename the functions and dataproviders to fix this

d8/core$ grep -nriI "\* @dataProvider" * --exclude-dir=vendor | grep -v " provider*"
modules/block/custom_block/tests/Drupal/custom_blocks/Tests/Menu/CustomBlockLocalTasksTest.php:39:   * @dataProvider getCustomBlockListingRoutes
modules/language/tests/Drupal/language/Tests/Menu/LanguageLocalTasks.php:38:   * @dataProvider getLanguageAdminOverviewRoutes
modules/simpletest/tests/Drupal/simpletest/Tests/TestBaseTest.php:64:   * @dataProvider randomStringValidateProvider
modules/user/tests/Drupal/user/Tests/Menu/UserLocalTasksTest.php:36:   * @dataProvider getUserAdminRoutes
modules/user/tests/Drupal/user/Tests/Menu/UserLocalTasksTest.php:57:   * @dataProvider getUserLoginRoutes
modules/user/tests/Drupal/user/Tests/Menu/UserLocalTasksTest.php:84:   * @dataProvider getUserPageRoutes
modules/taxonomy/tests/Drupal/taxonomy/Tests/Menu/TaxonomyLocalTasksTest.php:36:   * @dataProvider getTaxonomyPageRoutes
modules/aggregator/tests/Drupal/aggregator/Tests/Menu/AggregatorLocalTasksTest.php:36:   * @dataProvider getAggregatorAdminRoutes
modules/aggregator/tests/Drupal/aggregator/Tests/Menu/AggregatorLocalTasksTest.php:57:   * @dataProvider getAggregatorSourceRoutes
modules/shortcut/tests/Drupal/shortcut/Tests/Menu/ShortcutLocalTasksTest.php:39:   * @dataProvider getShortcutPageRoutes
modules/book/tests/Drupal/book/Tests/Menu/BookLocalTasksTest.php:39:   * @dataProvider getBookAdminRoutes
modules/book/tests/Drupal/book/Tests/Menu/BookLocalTasksTest.php:61:   * @dataProvider getBookNodeRoutes
modules/config/tests/Drupal/config/Tests/Menu/ConfigLocalTasksTest.php:36:   * @dataProvider getConfigAdminRoutes
modules/locale/tests/Drupal/locale/Tests/Menu/LocaleLocalTasksTest.php:38:   * @dataProvider getLocalePageRoutes
tests/Drupal/Tests/Core/Route/RoleAccessCheckTest.php:155:   * @dataProvider roleAccessProvider
tests/Drupal/Tests/Core/EventSubscriber/ModuleRouteSubscriberTest.php:56:   * @dataProvider testRemoveRouteProvider

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue categoryTask, because this is renaming some test methods.
Issue priorityNormal, because this issue improves naming.
Unfrozen changesUnfrozen, because it only changes tests.

Viewing all articles
Browse latest Browse all 294952

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>