Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 300728

ContextAwarePluginBase class not annotated as deprecated

$
0
0

Problem/Motivation

ContextAwarePluginBase was deprecated in #2273381: Convert ContextAwarePluginBase to traits.

However, only a runtime deprecation was added. The class phpDoc was not updated to include a @deprecated tag. This prevents it from being picked up my PHPStan's deprecation rules or other static analysis tools.

Steps to reproduce

Scan code extending the class using phpstan + phpstan-drupal + phpstan-deprecation-rules (aka drupal-check or upgrade_status). No error about a class extending this base class.

Proposed resolution

Add @deprecated

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 300728

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>