Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 291641

Stop ignoring "Missing explicit access check on entity query." rule in core/phpstan-baseline.neon

$
0
0

Problem/Motivation

Follow-up from #3279840: Update mglaman/phpstan-drupal.

In there we found that the rule for access check-checking on entity queries (introduced in mglaman/phpstan-drupal version 1.1.15) isn't fully working yet.

Since we wanted all the "goodness" that a jump from the at the time version 1.1.9 to 1.1.16 would bring, we decided to update to 1.1.16, _but_ ignoring the rule for that.

An entry in core/phpstan.neon.dist was made for ignoring this rule:

    # This check was ignored on purpose until the issues with it, which started in version 1.1.15, are solved.
    # @see
    - "#^Missing explicit access check on entity query.#"

Steps to reproduce

Proposed resolution

As soon as mglaman/phpstan-drupal cuts a release that solves all our issues with the above rule, remove the above lines from core/phpstan.neon.dist.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 291641

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>