Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 291711

Edit the file name for css files in help module

$
0
0

Problem/Motivation

The BAT (base-admin-theme) file organization we started to do in Drupal 8 was a fantastic idea. See http://drupal.org/node/1089868

It works really well, but its names conflict with the SMACSS categorization we're using in Drupal 8. "base" and "theme" means something else in SMACSS. So we just need to rename them.

Proposed resolution

MODULE.base.css becomes MODULE.module.css.
MODULE.admin.css stays the same (but requires adding a MODULE.admin.skin.css so admin themes can override the default skin).
And MODULE.theme.css becomes MODULE.skin.css.

In addition, since our template files are now in a templates sub-directory of a module, we should do the same for the CSS. Note that the toolbar, tour and views modules already do that.

This is part of the CSS standard described at http://drupal.org/node/1887922

This will be applied in help module

Remaining tasks

This issue is blocked by #1924436: Remove separate CSS_AGGREGATE_SYSTEM aggregate file

After this issue's completion, we still have all the other steps outlined at #1921610: [Meta] Architect our CSS.

User interface changes

none

API changes

The help.module's CSS files will have new names.


Viewing all articles
Browse latest Browse all 291711

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>