Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 296199

Update various module tests to not use Bartik and Seven

$
0
0

Problem/Motivation

There are several references to Bartik and Seven across various modules:

   1 core/modules/breakpoint/tests/src/Kernel/BreakpointDiscoveryTest.php
   1 core/modules/comment/tests/src/Functional/CommentDisplayConfigurableTest.php
   1 core/modules/editor/tests/src/Kernel/EditorImageDialogTest.php
   1 core/modules/search/tests/src/Functional/SearchAdminThemeTest.php
   1 core/modules/views/tests/src/Functional/UserBatchActionTest.php
   2 core/modules/responsive_image/tests/src/Unit/ResponsiveImageStyleConfigEntityUnitTest.php
   2 core/modules/views_ui/tests/src/Functional/ViewEditTest.php
   2 core/modules/ckeditor5/tests/src/Functional/AddedStylesheetsTest.php
   3 core/modules/jsonapi/tests/src/Functional/TermTest.php
   4 core/modules/menu_link_content/tests/src/Functional/MenuLinkContentTranslationUITest.php
   4 core/modules/node/tests/src/Functional/NodeTranslationUITest.php
   3 core/modules/block_content/tests/src/Functional/BlockContentTypeTest.php
   1 core/modules/node/tests/src/Functional/NodeDisplayConfigurableTest.php
   1 core/modules/views/tests/src/Kernel/Plugin/DisplayPageTest.php

These tests should be updated to either use Olivero, Claro, or System module's test_theme so we can deprecate Bartik #3249109: Deprecate Bartik in core once Olivero is the default theme and Seven #3084814: Deprecate Seven theme as mentioned at #3278124: Convert various tests that use bartik/seven to olivero/claro.

I've combined these into one issue as they didn't make the cut for my initial pass of complexity and number of references.

Steps to reproduce

git grep -E '(bartik)|(seven)' -- core/modules/breakpoint/tests/src/Kernel/BreakpointDiscoveryTest.php \
core/modules/comment/tests/src/Functional/CommentDisplayConfigurableTest.php \
core/modules/editor/tests/src/Kernel/EditorImageDialogTest.php \
core/modules/search/tests/src/Functional/SearchAdminThemeTest.php \
core/modules/views/tests/src/Functional/UserBatchActionTest.php \
core/modules/responsive_image/tests/src/Unit/ResponsiveImageStyleConfigEntityUnitTest.php \
core/modules/views_ui/tests/src/Functional/ViewEditTest.php \
core/modules/ckeditor5/tests/src/Functional/AddedStylesheetsTest.php \
core/modules/jsonapi/tests/src/Functional/TermTest.php \
core/modules/menu_link_content/tests/src/Functional/MenuLinkContentTranslationUITest.php \
core/modules/node/tests/src/Functional/NodeTranslationUITest.php \
core/modules/block_content/tests/src/Functional/BlockContentTypeTest.php \
core/modules/node/tests/src/Functional/NodeDisplayConfigurableTest.php \
core/modules/views/tests/src/Kernel/Plugin/DisplayPageTest.php \
| awk -F: '{print $1}' | sort | uniq -c

should return no results when this work is complete.

If any of these test updates turn out to be complex, we should split them off into a separate issue as it's unlikely there's any dependencies or shared code between these tests.

Remaining tasks

Update the tests.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

I don't think we need release notes or a change record.


Viewing all articles
Browse latest Browse all 296199

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>