Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295536

Update manager calls batch_process() directly from a form submit handler, preventing later submit handlers from running

$
0
0

On certain server setups, when installing or updating a module the Update Manager code will force the associated batch to be processed immediately from within a form submit handler. This means that any submit handlers that run afterwards will never run, since processing a batch calls drupal_goto().

The standard way to handle this situation is to let the form API initiate the batch process for you, since it automatically makes sure to process the batch only after all submit handlers have run. There's never really a good reason to call batch_process() yourself from within a form submit handler.

The attached patch makes the Update Manager use that method.


Viewing all articles
Browse latest Browse all 295536


<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>