Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 297347

Uncaught exception when data-caption contains markup upcasting to a model element

$
0
0

Problem/Motivation

We added support for markup in data-caption in #3222808: Follow-up for #3201646: markup in image captions is lost. However, we only ever tested data-caption with data that upcasts into $text. However, there are examples of valid child elements of <figcaption> that would upcast into a model element (e.g. <section> would be a valid child of <figcaption).

Steps to reproduce

  1. Create new text format that has Drupal Media + Image captions enabled and add <section> to source editable elements
  2. Create content using the new text format
  3. Embed media to the content and enable captions
  4. Add <section> to the data-caption value in source editing
  5. Return back to editing 💥

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 297347

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>