Problem/Motivation
NodeGrantDatabaseStorage::buildGrantsQueryCondition
doesn't have a scope.
Proposed resolution
Since
- The function is not called from anywhere but the class
- is not part of NodeGrantDatabaseStorageInterface
- is very much database specific
I suggest a protected scope.
Remaining tasks
User interface changes
API changes
Beta phase evaluation
Issue category | Bug because every method should have a scope. |
---|---|
Prioritized changes | This is a bugfix that makes this class a tiny bit less brittle. |
Disruption | Disruptive for contributed and custom modules if they called this method but the interface is not changed so that was bogus code already. |