Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 303517

buildGrantsQueryCondition is static and does not have a scope

$
0
0

Problem/Motivation

NodeGrantDatabaseStorage::buildGrantsQueryCondition doesn't have a scope.

Proposed resolution

Since

  1. The function is not called from anywhere but the class
  2. is not part of NodeGrantDatabaseStorageInterface
  3. is very much database specific

I suggest a protected scope.

Remaining tasks

User interface changes

API changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue categoryBug because every method should have a scope.
Prioritized changesThis is a bugfix that makes this class a tiny bit less brittle.
DisruptionDisruptive for contributed and custom modules if they called this method but the interface is not changed so that was bogus code already.

Viewing all articles
Browse latest Browse all 303517

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>