Problem/Motivation
We "solved" the problem of supporting <ol type>
and <ul type>
by using the SourceEditing
functionality for that.
But in CKEditor 5 32.0.0, they've added a native UX for setting the list type:
Which means that rather than having to edit HTML by hand, the content creator can now do that through the UI! But unfortunately, it currently always generates <ol style="list-style-type:SOMETHING">
and <ul style="list-style-type:SOMETHING">
, so we cannot use this.
This is blocked on https://github.com/ckeditor/ckeditor5/issues/11615.
It'd also improve the upgrade path because these attributes would no longer have to get set through the SourceEditing
functionality.
Steps to reproduce
N/A
Proposed resolution
See above.
Remaining tasks
- Set
styles.useAttribute = true
per https://github.com/ckeditor/ckeditor5/issues/11615, this ensures thetype
attribute will be generated instead of astyle
attribute - Expand the
- Add configuration to
\Drupal\ckeditor5\Plugin\CKEditor5Plugin\ListPlugin::buildConfigurationForm()
, to allow enabling thetype
attribute or not - Expand the config schema under
ckeditor5.plugin.ckeditor5_list
inckeditor5.schema.yml
- Expand unit test coverage in
\Drupal\Tests\ckeditor5\Unit\ListPluginTest
Optional: add more configuration to→ CKEditor 5 does not yet support restricting this to specific types.\Drupal\ckeditor5\Plugin\CKEditor5Plugin\ListPlugin::buildConfigurationForm()
, to allow configuring which listtype
attribute values are allowed. (e.g.type="A"
for<ol>
ortype="circle"
for<ul>
).
User interface changes
Extra configuration in UI:
@todo: screenshot
API changes
None.
Data model changes
None.
Release notes snippet
None.