Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295751

Clean up "layout" CSS in Bartik

$
0
0

Problem/Motivation

According to Drupal's CSS Standards...

Layout — macro arrangement of a web page, including any grid systems.

Therefore layout.css should only contain the basic page layout "grid" styles and nothing specific to particular components on the page
for eg. Float styles for sidebar should go into sidebar.css and padding styles for a particular component should go into the component files being referenced etc

Proposed resolution

Move any styles that do not belong in layout.css out into the relevant component files found in css/component/....
Clean up the relevant layout styles left in the file, make sure the CSS follows the CSS standards here.

Remaining tasks

Write a patch.
Visual review of the patch to check that nothing has changed + screenshots - we are not changing the design!
Code review of the patch to check the work is correct.

User interface changes

None, we are cleaning up CSS and markup in templates. The use of Bartik's UI and design will stay the same.

API changes

n/a

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue categoryTask because it is a code clean up overhaul of a theme.
Unfrozen changesUnfrozen because it only refactors CSS and templates, no changes to UI or APIs
Prioritized changesThe main goal of this issue is usability and performance. We want Bartik code to be up to date and something to be proud of.
DisruptionNo disruption it's only refactoring code not changing how to use the theme

Viewing all articles
Browse latest Browse all 295751


<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>