Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 293485

Consider CommentManagerInterface::addDefaultField() as deprecated and remove in favour of CommentTestTrait

$
0
0

Beta phase evaluation

-

Reference: https://www.drupal.org/core/beta-changes
Issue categoryTask because simplifies code introduced in 8.x...
Issue priorityNormal because planned clean-up
Prioritized changesThe main goal of this issue is removing previously introduced code that, if used, means that configuration is being created programatically rather than using CMI .
DisruptionDisruptive for contributed and custom modules if they use the method - however this was only introduced in 8.x.

Problem/Motivation

Helper method CommentManagerInterface::addDefaultField() is actively used by tests.
Usage in forum.install and standard.install removed in favour of shipped config files.

Proposed resolution

Let's mark the method as deprecated at least by pointing that comment field should be added via config file.
Move code from CommentManagerInterface::addDefaultField() to trait.
Usage in tests implemented via CommentTestTrait::addDefaultCommentField()

Remaining tasks

1. remove usage form *.install files and add default fields
2. agree on removal or deprecate
3. patch&commit

User interface changes

none

API changes

Removal of CommentManagerInterface::addDefaultField() in favour CommentTestTrait::addDefaultCommentField()


Viewing all articles
Browse latest Browse all 293485

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>