Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 299620

Move views_handler_field_custom_pre_render_move_text function to a class method on Drupal\views\Plugin\views\field\Custom

$
0
0

This is reliant on #1993312: Change pre_render and post_render callbacks to accept callables, but once in we can attach and render callbacks to plugins/handlers. This seems generally a nice idea to me. This function is only applicable to the Drupal\views\Plugin\views\field\Custom handler, but currently lives in views.module. Just doesn't make sense. Patch attached containing #1993312 also, if people want to test.

Steps to test:

- Add a 'Global: Custom text' field handler
- On the handler edit form 'Text' textarea should appear directly below the 'exclude from display' checkbox (screenshot attached)

AttachmentSizeStatusTest resultOperations
Screen Shot 2013-05-13 at 08.08.33.png33.49 KBIgnoredNoneNone
vdc.move-custom_pre_render-with-1993312.patch3.68 KBIdlePASSED: [[SimpleTest]]: [MySQL] 55,904 pass(es).View details | Re-test
vdc.move-custom_pre_render-do-not-test.patch1.77 KBIgnoredNoneNone

Viewing all articles
Browse latest Browse all 299620

Latest Images

Trending Articles



Latest Images

<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>