Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 294931

template_preprocess_views_ui_display_tab_setting() doesn't need two variables that mean the same thing.

$
0
0

This is a followup from #1843774: Convert views/views_ui/templates/views-ui-display-tab-setting.tpl.php to Twig.

The docs for template_preprocess_views_ui_display_tab_setting() say this:

+ *   - defaulted: A boolean indicating the setting is in it's default state.
+ *   - overridden: A boolean indicating the setting has been overridden from
+ *     the default.

Which implies that these two variables are just logical opposites of each other, ie. defaulted = !overridden. Either the docs are wrong/misleading or we don't need to set both of these variables.

However, this task should be postponed on #1987510: [meta] Convert all core *.tpl.php templates to Twig as singular patch.


Viewing all articles
Browse latest Browse all 294931

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>