Problem/Motivation
In #3350972: [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections() @nod_ introduced a "fix" for problems with the correct opening of an off-canvas dialog which potentially could fix all JS random test failures for tests using the library drupal.dialog.off_canvas
somehow.
This issue is a META to track-n-test all currently skipped FunctionalJavascript
tests that make use of that library.
The basic test for each issue would be:
- Unskip test.
- Run _only_ now unskipped test a lot of times (
usually we go for 1500x) as-is. - Run _only_ now unskipped test a lot of times (
usually we go for 1500x) _without_ the changes in #3350972: [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections(). - If 2, passes and 3 doesn't, we can safely turn the test back on again.
Per @xjm in #3353085-4: [meta] Determine impact of [#3350972] fix in off-canvas.js on currently disabled FunctionalJavascript tests we now need to go for a 5000-8000 times run for both patches.
Currently the library drupal.dialog.off_canvas
is used in:
- core/modules/layout_builder/layout_builder.libraries.yml
, so we need to check all skipped tests in core/modules/layout_builder/tests/src/FunctionalJavascript
.
- core/themes/stable9/stable9.info.yml
, so we need to check all skipped FunctionalJavascript
tests that use that theme.
- Just went through every skipped FunctionalJavascript
test.