Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 294262

Restore documentation on variable arguments in Drupal\Core\Database\Query\AlterableInterface::hasAllTags() and hasAnyTag() in Drupal 8.8

$
0
0

Problem/Motivation

In #3029500: Drupal\Core\Database\Query\Select::hasAllTags() and hasAnyTag() will require a new "$tags" argument in the next major version of its parent class we are removing documented variable arguments from Drupal\Core\Database\Query\AlterableInterface::hasAllTags() and hasAnyTag() because it generates deprecation errors due to the missing implementation in mock classes in tests.

Proposed resolution

In Drupal 8.8 we'll drop PHP 5 support and could possibly restore this documentation as a variadic (http://php.net/manual/en/functions.arguments.php#functions.variable-arg-...). From @alexpott:

Add back the @param but this time make it a proper variadic because then we've dropped PHP5 and then we can add the argument to the implementations so Symfony 4 doesn't trigger the deprecation and then finally in Drupal 9 we can add the variadic argument to the interface.

Remaining tasks

Discuss, implement in 8.8 once possible.

User interface changes

None.

API changes

None in Drupal 8.8, only the docs will return.

Data model changes

None.

Release notes snippet

N/A


Viewing all articles
Browse latest Browse all 294262

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>