Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295807

StatisticsLoggingTest does not truncate node_counter

$
0
0

Problem/Motivation

There is an old code in StatisticsLoggingTest::setUp() function, which is supposed to truncate data in node_counter table. But the statement is missing the execute() call, so this trucate is not working currently.

    // Clear the logs.
    Database::getConnection()->truncate('node_counter');

https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/statistics/tests/src/Functional/StatisticsLoggingTest.php#L103

There are two options - fix the truncate, or remove it entirely. It seems like it is not needed, as it is not causing any test failures. Therefore I think it will be feasible to remove it entirely.

Steps to reproduce

Proposed resolution

Fix the truncate call, or remove it entirely.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 295807

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>