[meeting] Migrate Meeting 2023-06-15 1400Z

Hello all, it’s time for the biweekly migration subsystem meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every second Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

Core migration issues

Next video meeting 2023-07-27 2100Z (tentative)

0️⃣ Who is here today?

mikelutz (he/him)	Hello
Dan Davis	Present - I am a newcomer to the migration group. Long time user, working on finding ways to contribute.
Stephanie	Hi - also looking to be contributing more

1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.

mikelutz (he/him)

#3247718: Allow process plugins to flag a row to be skipped

2️⃣ Action items. To be added later.

benjifisher	Review #3007709: Add XPath-style filtering ability in JSON data parser plugin. @benjifisher
benjifisher	Review #3063856: Expose full set of debugging data in migrate_message table (filterable/searchable). @benjifisher
benjifisher	Add some documentation for #3358569: Change plugin class for comment/user migration to the standard migration plugin class. @mikelutz (he/him)
benjifisher	Review #3247718: Allow process plugins to flag a row to be skipped. @benjifisher

3️⃣ Statistics

benjifisher	Fixed in the last 2 weeks: 1 (not counting issues for meetings). Another 2 in the previous two weeks.
benjifisher	RTBC: 3, all Normal priority, 1 has not been updated in more than 1 month.
benjifisher	NR: 1, including 1 Major.
benjifisher	Needs subsystem maintainer review: 8
benjifisher	Google sheet for recording stats: https://docs.google.com/spreadsheets/d/1o0Rjlc1vnnLP5bM5P-SMMyGzqn7258hi...

4️⃣ Comment in this thread if you are looking for ways to contribute. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...

Dan Davis	Documentation, code review, testing for me.
benjifisher	@Dan Davis: Are you interested in working on the issue in 9️⃣?
Dan Davis	Reviewing now

5️⃣ Previous minutes.

benjifisher

We skipped the 2023-06-01 meeting. Previous meetings have transcripts and are Closed (fixed). The latest was 2023-05-18: #3360195: [meeting] Migrate Meeting 2023-05-18 1400Z.

6️⃣ Announcements

benjifisher

Drupal 7 EOL is set for 2025-01-05, and there will be no more extensions.

The DA is working on a partner program for those who provide migration services. It is still in the early stages. For example, when asked about whether individual contractors can apply for the program, Tim Lehnen said they should think about it.

https://www.drupal.org/psa-2023-06-07

7️⃣ Consolidate code in the `migrate_drupal` module.

mikelutz (he/him)	Had a number of discussions regarding this and the future of migrate in Drupal core with the committers at DrupalCon.
mikelutz (he/him)	There isn’t a lot of consensus on how to proceed yet. One option discussed is to deprecate the d7/d6 stuff in Drupal 11 and NOT move it to contrib, in which case we don’t want to do the work to consolidate everything. We are going to have further dscussions at the next video meeting and the committers are going to have further disucssions as well. We probably want to postpone the issues here until those discussions are completed.
mikelutz (he/him)	We should definitly add it to the agenda for the next video meeting, (scheduled for July 27th atm). We should invite committers to join that meeting, Gabor/Nat/Jess and/or Alex if he’s back from holiday.
mikelutz (he/him)	And lets keep bringing it up in this meeting too. Everybody is busy with 10.1 right now, but if we don’t keep pressing for a decision, It’s going to slip through the cracks.
mikelutz (he/him)	And we want to have a decision by the end of the summer as it will dictate what we can or can’t do in 10.2 to prepare.
heddn	hmm, I like deprecate and remove in d12. less busy work.
benjifisher	The 21:00 UTC meetings conflict with the biweekly triage meeting for the security team. We may want to reschedule.

8️⃣ Add XPath-style filtering ability in JSON data parser plugin

benjifisher	#3007709: Add XPath-style filtering ability in JSON data parser plugin
benjifisher	@Stephanie did some manual testing last week during DrupalCon. It still needs code review. If I do a review and decide it needs some minor changes, is anyone available to make the updates?
Stephanie	I should have bandwidth for that.

9️⃣ Expose full set of debugging data in migrate_message table (filterable/searchable)

benjifisher	#3063856: Expose full set of debugging data in migrate_message table (filterable/searchable)
benjifisher	This issue is now un-postponed since #3312733: SQL migrations cannot be instantiated if database is not available and Node, Migrate Drupal modules are enabled was Fixed a few days ago.
benjifisher	Can someone check whether the patch in #141 still applies? When it was posted, it failed static analysis: `Running PHPStan on all files. ------ -------------------------------------------------------------------------------------- Line core/modules/migrate_drupal_ui/tests/src/Functional/MigrateMessageControllerTest.php ------ -------------------------------------------------------------------------------------- 49 Missing call to parent::setUp() method. ------ --------------------------------------------------------------------------------------` That should be pretty easy to fix.
benjifisher	I set the status to RTBC in #138, but @alexpott asked for changes in #139. Someone should confirm that the patch in #141 implements those changes.
benjifisher	Why did I set the status to RTBC before #3312733 was Fixed? It was fixed, but then it was reverted because tests failed with SQLite. It is now re-Fixed.

1️⃣0️⃣ Change plugin class for comment/user migration to the standard migration plugin class

benjifisher	#3358569: Change plugin class for comment/user migration to the standard migration plugin class
mikelutz (he/him)	This one has been coming up more and more in slack lately, where people can’t figure out why their custom processes don’t work in comment and user migrations, and it’s generally traced back to using the core migrations as a starting point, which use a custom migration class to dynamically inject processes.
benjifisher	@mikelutz (he/him): This one is for you! I think we skipped the 2023-06-02 meeting. You left a note on the issue for the previous meeting: Reminder for myself to discuss #3358569: Change plugin class for comment/user migration to the standard migration plugin class at this meeting. It's been coming up a lot in slack lately, and I think we need to at least improve documentation around the issue.
mikelutz (he/him)	I don’t think there is anything to do in core, but I’m thinking we can add some stuff in migrate_upgrade to adjust those migrations on export so people are starting with a more standard starting point. At minimum we need to probably document this somewhere along with the migrate_plus/migrate_upgrade workflow as it’s a common thing that’s overlooked.
benjifisher	Make that the 2023-06-01 meeting (off by a day). I will re-purpose that issue for today's meeting.
mikelutz (he/him)	hmm, I don’t recall intentionally skipping that meeting, but I was on vacation that week, I may not have seen the reminder for it and forgot about it. My bad.
mikelutz (he/him)	Given attendence at the later meeting lately, I’m guessing no one noticed, lol.
benjifisher	Maybe this is a good page to add some documentaiton: https://www.drupal.org/docs/upgrading-drupal/upgrading-from-drupal-6-or-...
mikelutz (he/him)	My calendar has been messed up since we dropped to every two weeks too, I’ve fixed it but that one may not have been on my calendar.
mikelutz (he/him)	Anyway, either document or fix migrate_upgrade to adjust those on export. but changing the export is probably tricky to do in general, and things like user_profile might make it tough. There’s also #3005718: D7 comment migration does not properly migrate fields by comment bundle.
mikelutz (he/him)	Maybe comments should be bundled after all and not use a custom class anyway.
mikelutz (he/him)	Oh.. I made that issue. huh.
benjifisher	Don't you love your past self? :wink:
mikelutz (he/him)	Am I right, are comments bundlable in d7, but we just try to migrate everything in one go? I feel like I remember seeing that 5 years ago, but haven’t given it much thought since then. I haven’t really migrated many sites with comments in my recent career.
benjifisher	I do not know.

1️⃣1️⃣ Allow process plugins to flag a row to be skipped (edited)

benjifisher	#3247718: Allow process plugins to flag a row to be skipped
benjifisher	I owe you a re-review of that one.

1️⃣2️⃣ Wrap up

benjifisher	Thanks for participating! I will update 2️⃣. Please continue to add comments in the threads. In 1-7 days, we will post a transcript for today's meeting.
benjifisher	It is great to see some more participation in today's meeting! I have to get to my day job now, but I will add action items later, and maybe even work on the ones assigned to me.
Dan Davis	Thank you @benjifisher!

Participants: