Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 299077

Fiber loops in Renderer and BigPipe are never suspended

$
0
0

Problem/Motivation

Fiber loops in Renderer and BigPipe are never suspended due to $iterations being reset at every iteration of the while loop

Steps to reproduce

  1. Create a placeholder callback that call Fiber::suspend at least twice
  2. Place breakpoint in the BigPipe.php:577 where it suspends to allow higher code to execute
  3. Iterations are always 0 so Fiber::suspend never called

It does not really affect anything yet because there are no higher fibers yet.

Proposed resolution

Move the $iterations declaration out of the while loops.

Remaining tasks

  • Move $iteration declarations
  • Provide tests if possible/needed

User interface changes

-

API changes

-

Data model changes

-

Release notes snippet

-


Viewing all articles
Browse latest Browse all 299077

Latest Images

Trending Articles



Latest Images